Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zic, tzselect: add page #14312

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

zic, tzselect: add page #14312

wants to merge 8 commits into from
+24 −0

Conversation

angadsgrover
Copy link
Contributor

@angadsgrover angadsgrover commented Oct 22, 2024 •
edited by sebastiaanspeck
Loading

Resolves #14018

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Oct 22, 2024
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/linux/tzselect.md:8:10 MD047/single-trailing-newline Files should end with a single newline character
pages/linux/tzselect.md:1: TLDR009 Page should contain a newline at end of file
pages/linux/zic.md:3: TLDR004 Command descriptions should end in a period
pages/linux/zic.md:6: TLDR005 Example descriptions should end in a colon with no trailing characters

Please fix the error(s) and push again.

@sebastiaanspeck sebastiaanspeck mentioned this pull request Oct 22, 2024
Open
3 tasks
sebastiaanspeck
sebastiaanspeck requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@sebastiaanspeck sebastiaanspeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, I still have some suggestions. After these are applied, it is GTG! 🚀

pages/linux/zic.md Outdated Show resolved Hide resolved
pages/linux/zic.md Outdated Show resolved Hide resolved
pages/linux/zic.md Outdated Show resolved Hide resolved
pages/linux/tzselect.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

@cyqsimon cyqsimon Awaiting requested review from cyqsimon cyqsimon is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's document: tzdata
3 participants
@angadsgrover @tldr-bot @sebastiaanspeck